-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support for stdin and piping #270
Conversation
- validate properly flushes output so pipes stdout works - lint accepts as input stdin (and pipe flows) - move all verbose option messages to stderr so that pipes also work with verbose output
A couple of comments about the code:
|
Disclaimer: I haven't tested it in Windows, I don't really have a setup available for it :-) |
This is of course also possible: (feat/stdin-support= dd9713a)$ ./speccy.js lint <<EOF
> openapi: 3.0.0
> info:
> contact:
> name: Derp
> email: derp@herp.com
> version: 1.0.0
> title: Swagger 2.0 Without Scheme
> paths: {}
> tags:
> - name: Gym
> - name: Pokemon
> EOF
Specification is valid, with 0 lint errors |
Looks good to me, thanks for your contribution! |
Successfully published:
|
May I ping you guys on this? The PR is already a month old but seems the project is a bit stalled and building a stack of PR's. I'm currently working from a fork of this but integrating the functionality directly in the published package would be great :-) Same goes for the fixes done by @MikeRalphson in Mermade/oas-kit#152 and (potentially if you agree with it) #294. Thanks! |
I can't merge PRs unfortunately, we have to ping @djtarazona or @smythey21 for merging PRs. |
Hey team, I will review this no later than this weekend. Sorry for the slowness on our side — we are working on getting better OSS processes in place and expect things to pick up soon. |
@dlouzan LGTM, and works in my local smoke testing. Can you rebase and fix any conflicts? Then I'll get this merged in. Thanks! |
Solve conflicts with latest master changes
I have just updated the branch, it was just some conflicts with the latest changes to package versions. |
Fixes #235