Config: prevent meaningless empty arrays override options in file #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdaloia
force-pushed
the
fix-empty-arrays-in-default-config
branch
from
21f7c31
to
c3c4d71
Compare
|
Looks good to me, @djtarazona this one can be tagged along in a new release. |
|
@mdaloia Feel free to resolve the conflicts and I'll take another look at merging this in. Thanks! |
The tests in lint.test.js fails if you have a speccy.yaml config file with 'verbose: true' because all the tests spying on the messages sent to the console through log(), warn() and error() methods and asserting the quantity of calls. Making it explicit as the default config for those tests allows us to run them even if we have a speccy.yaml in the root directory.
mdaloia
force-pushed
the
fix-empty-arrays-in-default-config
branch
from
e9ca21d
to
cc775db
Compare
It fixes the impossibility that the 'rules' and 'skip' options specified in speccy.yaml config file are used when these options are not override from command line. The Commander.js configuration has an empty array as a default/initial value for 'rules' and 'skip'. If you execute the lint command from the command line without specifying those arguments, when the config is loaded those 'supplied' literal config values (empty arrays) overrides the ones defined in a speccy.yaml file (because they are not 'undefined'). There is a test validating the config hierarchy but, as the configuration passed to init() is handcrafted, it wasn't simulating the output of Commander.js read options. Now, a test simulating this case was added.
mdaloia
force-pushed
the
fix-empty-arrays-in-default-config
branch
from
cc775db
to
a62c060
Compare
|
@djtarazona Done! Fixed and rebased with master. Thanks |
djtarazona
approved these changes
Jun 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It fixes the impossibility that the
rulesandskipoptions specified inspeccy.yamlconfig file are used when these options are not override from command line.The
Commander.jsconfiguration has an empty array as a default/initial value forrulesandskip. If you execute thelintcommand from the command line without specifying those arguments, when the config is loaded those 'supplied' literal config values (empty arrays) overrides the ones defined in aspeccy.yamlfile (because they are notundefined).There is a test validating the config hierarchy but, as the configuration passed to
init()is handcrafted, it wasn't simulating the output ofCommander.jsread options.Now, a test simulating this case was added.