Add OpenFlags for SFTP file open options #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wez
reviewed
Nov 28, 2023
nathaniel-daniel
force-pushed
the
sftp-open-flags
branch
from
a66a760
to
e1332b5
Compare
nathaniel-daniel
force-pushed
the
sftp-open-flags
branch
from
e1332b5
to
78fa0c9
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20
I chose to use bitflags since I didn't really feel strongly between the suggested options and bitflags are simpler to write.
I added the libc crate to provide the bitflag values.
I renamed the flags to be more descriptive, and added an alias for creating a new file since it felt fitting for a high level interface.
I did not add every possible flag from
open(2), since I'm fairly certain this subset of flags are the only meaningful ones.