Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EnumVariant/Enum<T>: Data race allowed on T #4090

Closed
wants to merge 1 commit into from
Closed

EnumVariant/Enum<T>: Data race allowed on T #4090

wants to merge 1 commit into from

Conversation

kuzeyardabulut
Copy link

Hi,
I found a memory-safety/soundness issue in this crate while scanning Rust code for potential vulnerabilities. This PR contains a fix for the issue.

Issue Description

EnumVariant<T> unconditionally implements Sync. This allows users to create data races on T: !Sync. Such data races can lead to undefined behavior.

unsafe impl<T> Send for EnumVariant<T> {}

same

unsafe impl<T> Send for Enum<T> {}

@wez
Copy link
Owner

wez commented Aug 3, 2023

FWIW, neither of those data types actually store an actual concrete instance of T; T is a present for its type signature only via a PhantomData, so I don't believe that there is really a race condition here, as it mentioned in the comments above the unsafe impl.

@kuzeyardabulut
Copy link
Author

FWIW, neither of those data types actually store an actual concrete instance of T; T is a present for its type signature only via a PhantomData, so I don't believe that there is really a race condition here, as it mentioned in the comments above the unsafe impl.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants