Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shell completion for homebrew installation #4204

Merged
merged 1 commit into from
Aug 27, 2023

Conversation

near129
Copy link
Contributor

@near129 near129 commented Aug 27, 2023

This pull request aims to enable automatic shell completion during the Homebrew installation process, similar to this reference. To achieve this, the pull request includes changes to incorporate shell completion scripts within the WezTerm.app.

related: wez/homebrew-wezterm#7

Note:
Upon successful merging and release of this pull request, it will be necessary to add the following code to the Homebrew Formula:

  binary "WezTerm.app/Contents/Resources/shell-completion/zsh",
         target: "#{HOMEBREW_PREFIX}/share/zsh/site-functions/_wezterm"
  binary "WezTerm.app/Contents/Resources/shell-completion/bash",
         target: "#{HOMEBREW_PREFIX}/etc/bash_completion.d/wezterm"
  binary "WezTerm.app/Contents/Resources/shell-completion/fish",
         target: "#{HOMEBREW_PREFIX}/share/fish/vendor_completions.d/wezterm.fish"

@wez wez merged commit b53a385 into wez:main Aug 27, 2023
15 checks passed
@wez
Copy link
Owner

wez commented Aug 27, 2023

Thanks!
Will you also submit PR(s) for the homebrew specific portions?

@near129
Copy link
Contributor Author

near129 commented Aug 28, 2023

OK. I have submitted it to wez/homebrew-wezterm#11.
Please note that this PR has not been released yet, so it cannot be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants