Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x11: Fix comment around modifiers merging, tweak changelog #4781

Closed
wants to merge 1 commit into from

Conversation

bew
Copy link
Contributor

@bew bew commented Jan 12, 2024

refs: #4151

@bew
Copy link
Contributor Author

bew commented Jan 18, 2024

Friendly ping @wez, this is a short comment PR
Build failure is unrelated

@wez
Copy link
Owner

wez commented Jan 18, 2024

re: build failure, I think I'll just remove centos 7. It's EOL and not worth the effort to try to keep it going any more.

I was holding off on this PR for the moment, because I'm wondering if unconditionally merging of the modifiers is the cause of #4776 but we haven't had feedback on that yet.

Also, something weird I've noted once or twice in the past week is that if I resize wezterm, sometimes vim mysteriously gets suspend as though I typed ctrl-z. I don't know if this is just some crazy unrelated thing or if there is some weird stuff happening with input on this system--it doesn't seem like resizing with the mouse would be connected to input, but also: it seems weird that the modifiers spontaneously get reset to 0 here. I haven't had time/motivation to sit down and debug it.

@bew
Copy link
Contributor Author

bew commented Jan 18, 2024

Your modifiers reset is definitely weird 😬
But this PR doesn't change any code, only makes it clearer imo (by moving & reworking the comment).

I'm thinking your weird behavior could be tracked in a separate issue?
(which might end up reverting / reworking the code for mods merge)

@wez wez closed this in c4970b7 Jan 21, 2024
@bew bew deleted the patch-1 branch January 22, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants