Fix interaction between pane swapping / rotating and client domains. #5009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdan2412
force-pushed
the
fix-client-domain-pane-swapping
branch
from
3941fdc
to
9d9749a
Compare
This should address wez#4200. Currently pane swapping and rotation only works correctly on local domains since none of the state is propagated to the remote mux server. This patch adds a couple of RPCs for rotating panes and for swapping an active pane with the pane at a given index. Additionally, it renames the corresponding methods on the `mux::tab` module, prefixing them with `local_`, adds `remote_` versions of them to Domains and adds a convenience method on `mux`, mirroring the pattern used for `move_pane_to_new_tab`, which dispatches to the relevant method. This incidentally fixes a typo in the Lua API which was previously always rotating panes in a single direction.
bogdan2412
force-pushed
the
fix-client-domain-pane-swapping
branch
from
9d9749a
to
0f36595
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should address #4200.
Currently pane swapping and rotation only works correctly on local domains since none of the state is propagated to the remote mux server.
This patch adds a couple of RPCs for rotating panes and for swapping an active pane with the pane at a given index. Additionally, it renames the corresponding methods on the
mux::tabmodule, prefixing them withlocal_, addsremote_versions of them to Domains and adds a convenience method onmux, mirroring the pattern used formove_pane_to_new_tab, which dispatches to the relevant method.This incidentally fixes a typo in the Lua API which was previously always rotating panes in a single direction.