Fix macOS notch avoidance padding in full screen mode #5515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #3807 The values returned by [`safeAreaInsets`][0] need to be multipled by the scale factor of the display (in case of the MacBook Pro 14-inch, 2021, a value of 2.0). There's a code comment referencing [#1737 (comment)][1], where an extra `2` was added to this number, but something must have changed since then because I cannot see a need for this now. [0]: https://developer.apple.com/documentation/appkit/nsscreen/3882821-safeareainsets [1]: #1737 (comment)
mbaird
changed the title
wez
added a commit
that referenced
this pull request
Jun 8, 2024
|
Thanks! |
saep
pushed a commit
to saep/wezterm
that referenced
this pull request
Jul 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3807
The values returned by
safeAreaInsetsneed to be multipled by the scale factor of the display (in case of the MacBook Pro 14-inch, 2021, a value of 2.0).There's a code comment referencing #1737 (comment), where an extra
2was added to this number, but something must have changed since then because I cannot see a need for this now.(Not familiar with Rust, so let me know if there's a better way to write this!)