Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Identify modifiers on Wayland/X11 (new) #5850

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

gabyx
Copy link
Contributor

@gabyx gabyx commented Jul 24, 2024

Fixes: #4626

  • This implementation is the first modifier detection client-side workaround as Kitty does for Wayland.
  • For X11 the code checks the modifier table and tries to match a single virtual modifiers to a single real modifier (ctrl, shift, capslock, mod1...mod5).
  • On Wayland the workaround goes by probing the keyboard for all keys and rebuilding the missing API which is not available as in X11.

The solution is encapsulated out in file modifiers.rs for both X11 and Wayland.

  • I am sure about how to test this, since it uses xkb and its state...
  • @wez: A review is appreciated to let me know if we should go on with this, or there is any better idea from your side.
    This PR contains the port of Kittys C code for Wayland.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: Implement modifier detection on wayland/x11
1 participant