Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Able to drop into gsp with no changes in the directory #369

Closed
2 of 7 tasks
cjappl opened this issue Mar 18, 2024 · 0 comments · Fixed by #376
Closed
2 of 7 tasks

Able to drop into gsp with no changes in the directory #369

cjappl opened this issue Mar 18, 2024 · 0 comments · Fixed by #376
Assignees
@sandr01d

Comments

@cjappl
Copy link
Collaborator

cjappl commented Mar 18, 2024

Environment info

  • OS
    • Linux
    • Mac OS X
    • Windows
    • Others:
  • Shell
    • bash
    • zsh
    • fish

Problem / Steps to reproduce

1. Have clean directory, no changes no added files
2. gsp

Expected:
Nothing happens, gsp exits early, just like if you ga with "Nothing to add"

Observed:
Fzf pops up but the list is empty, user can do nothing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sandr01d sandr01d

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Early out from _forgit_stash_push when no files can be stashed sandr01d/forgit
2 participants
@cjappl @sandr01d