Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Early out from _forgit_stash_push when no files can be stashed #376

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

sandr01d
Copy link
Collaborator

Check list

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation

Description

Previously when using gsp without any local changes, an empty file picker would open. Check if any files can be stashed and show a message instead when this isn't the case.
Fixes #369

Type of change

  • Bug fix
  • New feature
  • Refactor
  • Breaking change
  • Documentation change

Test environment

  • Shell
    • bash
    • zsh
    • fish
  • OS
    • Linux
    • Mac OS X
    • Windows
    • Others:

Copy link
Collaborator

@cjappl cjappl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@carlfriedrich
Copy link
Collaborator

carlfriedrich commented Mar 30, 2024

Why not simply use fzf's --exit-0 argument for this?

@sandr01d
Copy link
Collaborator Author

Why not simply use fzf's --exit-0 argument for this?

@carlfriedrich wasn't aware this exists, thanks! Updated accordingly.

@sandr01d
Copy link
Collaborator Author

@carlfriedrich could you let me know if the change works like this for you?

Copy link
Collaborator

@carlfriedrich carlfriedrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I overlooked this. Works for me, thanks for the update!

@sandr01d sandr01d merged commit 2903fef into wfxr:master Apr 23, 2024
4 checks passed
@sandr01d sandr01d deleted the gsp-early-out branch April 26, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Able to drop into gsp with no changes in the directory
3 participants