Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: example of using config vars to sort git branch #319

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

iloveitaly
Copy link
Contributor

Check list

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation

Description

Docs with an example of using a config var to customize gcb

Type of change

  • Bug fix
  • New feature
  • Refactor
  • Breaking change
  • Documentation change

Test environment

  • Shell
    • bash
    • zsh
    • fish
  • OS
    • Linux
    • Mac OS X
    • Windows
    • Others:

Copy link
Collaborator

@sandr01d sandr01d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @iloveitaly! Having an example here makes sense to me. Requesting a review from @cjappl, since you reviewed #307, but I think we can merge this soon.

@sandr01d sandr01d requested a review from cjappl July 12, 2023 17:51
Copy link
Collaborator

@cjappl cjappl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Thanks for the contribution! Will merge

@cjappl cjappl merged commit f1ac9e3 into wfxr:master Jul 12, 2023
4 checks passed
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's a typo here. Shouldn't it be

FORGIT_CHECKOUT_BRANCH_GIT_OPTS

instead of

FORGIT_CHECKOUT_BRANCH_BRANCH_GIT_OPTS

?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's a typo here. Shouldn't it be

FORGIT_CHECKOUT_BRANCH_GIT_OPTS

instead of

FORGIT_CHECKOUT_BRANCH_BRANCH_GIT_OPTS

?

Both exist, see

cmd="git branch --color=always ${FORGIT_CHECKOUT_BRANCH_BRANCH_GIT_OPTS:---all} | LC_ALL=C sort -k1.1,1.1 -rs"

FORGIT_CHECKOUT_BRANCH_BRANCH_GIT_OPTS is passed the command that retrieves the branches, FORGIT_CHECKOUT_BRANCH_GIT_OPTS is passed to the git checkout command.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sandr01d Ah, thanks for clarifying, and sorry for the noise! 🙈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants