Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where homebrew replacement wouldn't work #379

Merged
merged 1 commit into from
Mar 30, 2024
Merged

Conversation

cjappl
Copy link
Collaborator

@cjappl cjappl commented Mar 30, 2024

Check list

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation

Description

In our homebrew formula, we were replacing this line in the installation:

 Replace this:             'set -x FORGIT "$FORGIT_INSTALL_DIR/bin/git-forgit"',
  with this     :             "set -x FORGIT \"#{opt_prefix}/bin/git-forgit\""

However, later in the fish script, we ignored that, just basing it directly off of the install dir:

alias git-forgit "$FORGIT_INSTALL_DIR/bin/git-forgit"

This makes sure that we always line up and don't have `fish: Unknown command: /opt/homebrew/share/conf.d/bin/git-forgit

Fixes #377

Type of change

  • Bug fix

Test environment

  • Shell
    • bash
    • zsh
    • fish
  • OS
    • Linux
    • Mac OS X
    • Windows
    • Others:

Copy link
Owner

@wfxr wfxr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cjappl cjappl merged commit 0a89d21 into master Mar 30, 2024
7 checks passed
@cjappl cjappl deleted the fix-brew-forgit branch March 30, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Brew installation of fish shell plugin failing
2 participants