Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a preview to _forgit_clean #383

Merged
merged 3 commits into from
Apr 19, 2024
Merged

Conversation

sandr01d
Copy link
Collaborator

@sandr01d sandr01d commented Apr 9, 2024

Check list

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation

Description

gclean is the only command that does not display a preview. I sometimes find myself exiting gclean just to check the content of a file before deleting it. Being able to have a last peek at a file before removing it does sound like a good idea in general to me.

Type of change

  • Bug fix
  • New feature
  • Refactor
  • Breaking change
  • Documentation change

Test environment

  • Shell
    • bash
    • zsh
    • fish
  • OS
    • Linux
    • Mac OS X
    • Windows
    • Others:

Copy link
Collaborator

@carlfriedrich carlfriedrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, works for me!

@sandr01d
Copy link
Collaborator Author

FYI: I've added a preview for directories now as well (before this you'd see an unwanted error message when trying to preview a directory). Looks like this when tree is installed

image

Otherwise like this:

image

Feel free to give this another review if you like. Will keep testing this for a few days.

bin/git-forgit Outdated Show resolved Hide resolved
@sandr01d sandr01d merged commit bc408f1 into wfxr:master Apr 19, 2024
4 checks passed
@sandr01d sandr01d deleted the gclean-preview branch April 26, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants