Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typos suggestion #390

Merged
merged 3 commits into from
Apr 24, 2024
Merged

typos suggestion #390

merged 3 commits into from
Apr 24, 2024

Conversation

ccoVeille
Copy link
Contributor

Check list

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation

Description

  • Fix some typos and wordings in README.md
  • Fix headers style
  • Fix exemplī grātiā usage (Latin)

Type of change

  • Bug fix
  • New feature
  • Refactor
  • Breaking change
  • Documentation change

Test environment

  • Shell
    • bash
    • zsh
    • fish
  • OS
    • Linux
    • Mac OS X
    • Windows
    • Others:

Copy link
Collaborator

@sandr01d sandr01d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

README.md Outdated Show resolved Hide resolved
Copy link
Owner

@wfxr wfxr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ccoVeille. Mostly LGTM, except for a minor comment.

- don't not mix `eg` and `e.g.` in the same document.
- use the US form of `e.g.`, so followed with a comma.

https://en.wiktionary.org/wiki/e.g.
@carlfriedrich
Copy link
Collaborator

@ccoVeille Thanks for your contribution, looks good to me.

@carlfriedrich carlfriedrich merged commit f3616b0 into wfxr:master Apr 24, 2024
4 checks passed
@ccoVeille ccoVeille deleted the typos-suggestion branch April 24, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants