Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

healthcheckエンドポイントを作成した #33

Merged
merged 2 commits into from
Mar 26, 2020

Conversation

MasashiFujiike
Copy link
Contributor

@MasashiFujiike MasashiFujiike commented Mar 25, 2020

Issue

close #32

背景

ingressがサービスの死活監視をする際にヘルスチェックする必要があるのだが、この対象になるエンドポイントがなかったので作った。

追記

外部サービス(GKE)の都合だが、ヘルスチェックエンドポイントは / でないとヘルスチェックに通らないため、 / を対象のエンドポイントにした。

kubernetes/ingress-gce#39
kubernetes/ingress-gce#42

@MasashiFujiike MasashiFujiike self-assigned this Mar 25, 2020
Copy link
Collaborator

@shigeru10 shigeru10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

readiness, livenessは別途設定ということであってますか??
https://qiita.com/toshihirock/items/c7e94e70c1c9650488df

@MasashiFujiike
Copy link
Contributor Author

@shigeru10

readiness, livenessは別途設定ということであってますか??
あってます。あくまでapi側の受け口として用意してて、readinessProbeとかはdevops側でやる予定です

@shigeru10
Copy link
Collaborator

たしかに、別レポジトリでしたね

Copy link
Collaborator

@shigeru10 shigeru10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

あ、もう一つなんですが、GKEで /が200じゃないとエラーが起こるかもしれないので覚えておいてもらうと良さそうです

@codecov
Copy link

codecov bot commented Mar 26, 2020

Codecov Report

Merging #33 into master will not change coverage by %.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #33   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines          663       666    +3     
=========================================
+ Hits           663       666    +3     
Impacted Files Coverage Δ
app/presentation/router.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 083871c...d414cd1. Read the comment docs.

@MasashiFujiike MasashiFujiike merged commit 95dc2db into master Mar 26, 2020
@MasashiFujiike MasashiFujiike deleted the 32-introduce-healthcheck-endpoint branch March 26, 2020 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

healthcheckエンドポイントを作る
2 participants