This repository has been archived by the owner on Jul 25, 2022. It is now read-only.
Don't use try_acquire alongside spawned task #2165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're hitting an issue that looks similar to launchbadge/sqlx#622 I was able to work around it by disabling fairness, but we can just avoid the lookup entirely if active workers is >= the pool size. Signed-off-by: Joe Grund <jgrund@whamcloud.io>
ip1981
approved these changes
Aug 18, 2020
utopiabound
approved these changes
Aug 18, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're hitting an issue that looks similar to
launchbadge/sqlx#622
I was able to work around it by disabling fairness, but we can just
avoid the lookup entirely if active workers is >= the pool size.
Signed-off-by: Joe Grund jgrund@whamcloud.io
This change is