Skip to content
This repository has been archived by the owner on May 21, 2024. It is now read-only.

Add more recovery stats #61

Merged
merged 5 commits into from
Mar 6, 2024
Merged

Add more recovery stats #61

merged 5 commits into from
Mar 6, 2024

Conversation

RDruon
Copy link
Contributor

@RDruon RDruon commented Jul 11, 2023 •
edited
Loading

Fix #55. See updated snapshot

@RDruon RDruon added the enhancement New feature or request label Jul 11, 2023
@RDruon RDruon requested a review from jgrund July 11, 2023 14:50
@RDruon RDruon self-assigned this Jul 11, 2023
RDruon
RDruon commented Jul 11, 2023
View reviewed changes
src/recovery_status_parser.rs Outdated Show resolved Hide resolved
@RDruon RDruon marked this pull request as ready for review July 12, 2023 14:40
jgrund
jgrund reviewed Jul 14, 2023
View reviewed changes
src/base_parsers.rs Outdated Show resolved Hide resolved
jgrund
jgrund suggested changes Jul 14, 2023
View reviewed changes
Copy link
Member

@jgrund jgrund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

till_eof seems like a bug. We shouldn't have a case where we need to eat (and discard) every char.

This indicates a parsing gap on our end.

@RDruon RDruon requested a review from jgrund July 17, 2023 09:52
jgrund
jgrund reviewed Mar 1, 2024
View reviewed changes
Copy link
Member

@jgrund jgrund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add unit tests and full fixtures here.

@RDruon
Copy link
Contributor Author

RDruon commented Mar 4, 2024

Do we need a new fixtures? This param was already captured but not parsed

@jgrund jgrund merged commit 6678944 into master Mar 6, 2024
5 checks passed
@jgrund jgrund deleted the rdruon/55 branch March 6, 2024 14:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jgrund jgrund jgrund approved these changes

Assignees

@RDruon RDruon

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for mdt recovery status
2 participants
@RDruon @jgrund