Skip to content
This repository has been archived by the owner on May 21, 2024. It is now read-only.

types: Fix deserialize of UnsignedLustreTimestamp #74

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

utopiabound
Copy link
Contributor

@utopiabound utopiabound commented Dec 6, 2023

Serialize / Deserialize UnsignedLustreTimestamp as string.
Add test to fully serialize / deserialize an lctl get_param dump.

@utopiabound utopiabound added the bug Something isn't working label Dec 6, 2023
@utopiabound utopiabound requested review from jgrund and a team December 6, 2023 19:42
@utopiabound utopiabound self-assigned this Dec 6, 2023
@jgrund jgrund changed the title EX-8761 types: Fix deserialize of UnsignedLustreTimestamp types: Fix deserialize of UnsignedLustreTimestamp Dec 6, 2023
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
Copy link
Member

@jgrund jgrund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor things, otherwise looks good

Serialize / Deserialize UnsignedLustreTimestamp as string
Add test to fully serialize / deserialize an lctl get_param dump.

Signed-off-by: Nathaniel Clark <Nathaniel.Clark@misrule.us>
@jgrund jgrund merged commit 8c90c51 into master Dec 6, 2023
5 checks passed
@jgrund jgrund deleted the nclark/job-stats branch December 6, 2023 20:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants