This repository has been archived by the owner on May 21, 2024. It is now read-only.
health_check: Allow "unhealthy" #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgrund
reviewed
Dec 7, 2023
|
Can such string occurs? From the code it seems to be either |
RDruon
suggested changes
Dec 7, 2023
utopiabound
force-pushed
the
nclark/unhealthy
branch
from
5afc42f to
566ad7d
Compare
jgrund
suggested changes
Dec 7, 2023
utopiabound
force-pushed
the
nclark/unhealthy
branch
from
566ad7d to
c6e4413
Compare
Fix regression to allow bare "NOT HEALTH" and "LBUG" to be returned for health_check. Signed-off-by: Nathaniel Clark <nclark@whamcloud.com>
utopiabound
force-pushed
the
nclark/unhealthy
branch
from
c6e4413 to
f309377
Compare
RDruon
previously approved these changes
Dec 7, 2023
Use 6.2.0 fixture to test NOT HEALTHY Signed-off-by: Nathaniel Clark <nclark@whamcloud.com>
jgrund
reviewed
Dec 8, 2023
| healthy: false, | ||
| targets: vec![], | ||
| })), | ||
| (string("NOT HEALTHY").map(|_| HealthCheckStat { |
There was a problem hiding this comment.
Nits:
- This should be a const since we repeat it below
- We should condense these two blocks with an
or
jgrund
approved these changes
Dec 8, 2023
If there is a libcfs catastrophe : |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix regression to allow bare "unhealthy" to be returned for health_check.
Also update version to 0.7.7