Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: refactor response's location URL so it's always present #958

Closed
annevk opened this issue Nov 5, 2019 · 0 comments · Fixed by #1149
Closed

Editorial: refactor response's location URL so it's always present #958

annevk opened this issue Nov 5, 2019 · 0 comments · Fixed by #1149
Labels
clarification Standard could be clearer good first issue Ideal for someone new to a WHATWG standard or software project

Comments

@annevk
Copy link
Member

annevk commented Nov 5, 2019

Members that are conditionally present are hard to work with. We should just make it take several 3 string enum values or a URL and convert null and failure to 2 of those string enum values as we get a result from the header parser (the third value being the default).
@annevk annevk added good first issue Ideal for someone new to a WHATWG standard or software project clarification Standard could be clearer labels Nov 5, 2019
@annevk annevk mentioned this issue Feb 12, 2020
Merged
annevk added a commit that referenced this issue Jan 29, 2021
@annevk
Remove location URL as field on responses
3a28eee 
It does not need to be stored on a response and therefore resulted in confusion.

Also clarify that synthetic responses need to have an absolute URL in the Location header field value (Response.redirect() does this automatically).

Corresponding HTML PR: TODO.

Tests: TODO.

Closes #631, closes #633, closes #958, and closes #1146. (Some of these can be closed due to #1030 making response's URL no longer null for network responses.)
@annevk annevk mentioned this issue Jan 29, 2021
Merged
3 tasks
annevk added a commit that referenced this issue Feb 1, 2021
@annevk
Remove location URL as field on responses
e63e41a 
It does not need to be stored on a response and therefore resulted in confusion.

Also clarify that synthetic responses need to have an absolute URL in the Location header field value (Response.redirect() does this automatically).

Corresponding HTML PR: TODO.

Tests: TODO.

Closes #631, closes #633, closes #958, and closes #1146. (Some of these can be closed due to #1030 making response's URL no longer null for network responses.)
annevk added a commit that referenced this issue Feb 2, 2021
@annevk
Remove location URL as field on responses
89cfc1d 
It does not need to be stored on a response and therefore resulted in confusion.

Also clarify that synthetic responses need to have an absolute URL in the Location header field value (Response.redirect() does this automatically).

Corresponding HTML PR: whatwg/html#6340.

Tests: https://chromium-review.googlesource.com/c/chromium/src/+/2665871.

Closes #631, closes #633, closes #958, closes #1146, and closes web-platform-tests/wpt#10449. (Some of these can be closed due to #1030 making response's URL no longer null for network responses.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
clarification Standard could be clearer good first issue Ideal for someone new to a WHATWG standard or software project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove location URL as field on responses whatwg/fetch
1 participant
@annevk