Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Account for localhost. (with trailing dot) in origin resolving #1431

Merged
merged 1 commit into from
May 3, 2022
Merged

Account for localhost. (with trailing dot) in origin resolving #1431

merged 1 commit into from
May 3, 2022

Conversation

annevk
Copy link
Member

@annevk annevk commented May 2, 2022 •
edited by pr-preview bot
Loading

See whatwg/url#693 for context.

@mikewest want to review?

Preview | Diff

@annevk annevk requested a review from mikewest May 2, 2022 12:29
mikewest
mikewest approved these changes May 3, 2022
View reviewed changes
Copy link
Member

@mikewest mikewest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy enough, LGTM.

Last I checked, we can't test this through WPT because neither localhost nor 127.0.0.1 are consistently available given the environment. Landing without additional tests in that case seems reasonable.

@annevk annevk merged commit 3ae445e into main May 3, 2022
@annevk annevk deleted the annevk/localhost-trailing-dot branch May 3, 2022 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikewest mikewest mikewest approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@annevk @mikewest