Refactor the CORS check #824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular, make it use header list's get operation to retrieve the Access-Control-Allow-Origin and Access-Control-Allow-Credentials values. Tests: web-platform-tests/wpt#13815.
annevk
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Nov 1, 2018
|
I also created web-platform-tests/wpt#13841 which shows the exact same browser bugs for |
|
(I'd prefer review for PRs like this, but since it's hard to get them for Fetch I'll sometimes merge if all the other boxes are ticked. If you'd like me to stop doing this please let me know, but then we also need to figure out the reviewer situation.) |
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Nov 10, 2018
…parsing, a=testonly Automatic update from web-platform-testsFetch: Access-Control-Allow-Credentials parsing For whatwg/fetch#824. -- wpt-commits: 43452a39a63658cd6cbaaefcc3d7056e21a18db5 wpt-pr: 13841
jyc
pushed a commit
to jyc/gecko
that referenced
this pull request
Nov 11, 2018
…parsing, a=testonly Automatic update from web-platform-testsFetch: Access-Control-Allow-Credentials parsing For whatwg/fetch#824. -- wpt-commits: 43452a39a63658cd6cbaaefcc3d7056e21a18db5 wpt-pr: 13841
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 3, 2019
…parsing, a=testonly Automatic update from web-platform-testsFetch: Access-Control-Allow-Credentials parsing For whatwg/fetch#824. -- wpt-commits: 43452a39a63658cd6cbaaefcc3d7056e21a18db5 wpt-pr: 13841 UltraBlame original commit: ad7e46baf65c342aea771f1539b22c8db961e965
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 3, 2019
…parsing, a=testonly Automatic update from web-platform-testsFetch: Access-Control-Allow-Credentials parsing For whatwg/fetch#824. -- wpt-commits: 43452a39a63658cd6cbaaefcc3d7056e21a18db5 wpt-pr: 13841 UltraBlame original commit: ad7e46baf65c342aea771f1539b22c8db961e965
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 3, 2019
…parsing, a=testonly Automatic update from web-platform-testsFetch: Access-Control-Allow-Credentials parsing For whatwg/fetch#824. -- wpt-commits: 43452a39a63658cd6cbaaefcc3d7056e21a18db5 wpt-pr: 13841 UltraBlame original commit: ad7e46baf65c342aea771f1539b22c8db961e965
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular, make it use header list's get operation to retrieve the Access-Control-Allow-Origin and Access-Control-Allow-Credentials values.
Tests: web-platform-tests/wpt#13815.