Be strict on request's Content-Type #829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests: web-platform-tests/wpt#13921. Helps with #814.
annevk
commented
Nov 5, 2018
| <li><p>If <var>mimeType</var>'s <a for="MIME type">essence</a> is not | ||
| "<code>application/x-www-form-urlencoded</code>", "<code>multipart/form-data</code>", or | ||
| "<code>text/plain</code>", then return false. | ||
| </ol> |
There was a problem hiding this comment.
It would be good to add a note here illustrating that this is very different from how response Content-Type is parsed, but maybe that should wait until that's actually defined properly.
There was a problem hiding this comment.
I'll do this as part of #529.
|
Bugs:
I plan on merging this soonish, unless someone volunteers to review. |
yutakahirano
approved these changes
Nov 9, 2018
annevk
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Nov 9, 2018
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Nov 14, 2018
Following the corresponding spec change: whatwg/fetch#829 Bug: 902681 Change-Id: If0da598ada489417c34926935acdd3cfff519aa7 Reviewed-on: https://chromium-review.googlesource.com/c/1329815 Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#607847}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Nov 14, 2018
…eader, a=testonly Automatic update from web-platform-testsFetch: CORS and request's Content-Type header For whatwg/fetch#829. -- wpt-commits: eed621bc2f995bced9481df2cead4c4632c72cdd wpt-pr: 13921
staktrace
pushed a commit
to staktrace/gecko
that referenced
this pull request
Nov 15, 2018
…eader, a=testonly Automatic update from web-platform-testsFetch: CORS and request's Content-Type header For whatwg/fetch#829. -- wpt-commits: eed621bc2f995bced9481df2cead4c4632c72cdd wpt-pr: 13921
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 3, 2019
…eader, a=testonly Automatic update from web-platform-testsFetch: CORS and request's Content-Type header For whatwg/fetch#829. -- wpt-commits: eed621bc2f995bced9481df2cead4c4632c72cdd wpt-pr: 13921 UltraBlame original commit: 7f3034a3afb3e49f04faf7b21bf4bc7c597e285c
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 3, 2019
…eader, a=testonly Automatic update from web-platform-testsFetch: CORS and request's Content-Type header For whatwg/fetch#829. -- wpt-commits: eed621bc2f995bced9481df2cead4c4632c72cdd wpt-pr: 13921 UltraBlame original commit: 7f3034a3afb3e49f04faf7b21bf4bc7c597e285c
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 3, 2019
…eader, a=testonly Automatic update from web-platform-testsFetch: CORS and request's Content-Type header For whatwg/fetch#829. -- wpt-commits: eed621bc2f995bced9481df2cead4c4632c72cdd wpt-pr: 13921 UltraBlame original commit: 7f3034a3afb3e49f04faf7b21bf4bc7c597e285c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests: web-platform-tests/wpt#13921.
Helps with #814.