Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Strong reference" cleanup #4386

Closed
annevk opened this issue Feb 22, 2019 · 1 comment
Closed

"Strong reference" cleanup #4386

annevk opened this issue Feb 22, 2019 · 1 comment

Comments

@annevk
Copy link
Member

annevk commented Feb 22, 2019

I think once #4350 lands we should remove everything before "discard" in https://html.spec.whatwg.org/#garbage-collection-and-browsing-contexts. And we should also remove https://html.spec.whatwg.org/#garbage-collection.

The "modern" way of doing this is by keeping references in slots and all references are strong. If there's an actual non-strong reference this would have to be called out explicitly and defined.
@domenic
Copy link
Member

domenic commented Feb 22, 2019

However, I think that per #3863, it would still be good to add a diagram summarizing the references that are scattered around.

annevk added a commit that referenced this issue Feb 22, 2019
@annevk
Editorial: remove redundant strong reference talk
3cc7544 
All these references are already explicit (usually via "internal slots" on the objects) and they are strong by default, so there's no need to state this separately.

Closes #4386.
@annevk annevk mentioned this issue Feb 22, 2019
Merged
annevk added a commit that referenced this issue Feb 23, 2019
@annevk
Editorial: remove redundant strong reference talk
3274a60 
All these references are already explicit (usually via "internal slots" on the objects) and they are strong by default, so there's no need to state this separately.

Closes #4386.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@domenic @annevk