Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new attribute called
writingsuggestions
to control UA-provided writing assistance #10018Add a new attribute called
writingsuggestions
to control UA-provided writing assistance #10018Changes from 7 commits
5a3eac7
26daf8a
c9abb7a
ea0bfc1
abc1c85
95524a1
9aecd89
7fda857
d119757
ccaac6c
ac65d83
d16055e
71cdc44
d5a1d16
1482e04
2c9f530
a7481ab
3ba33e6
b6a32bb
7cdd6d5
15dfeca
ecb2b3d
8e850bd
f29afd0
443fd10
2b0ab55
f68ba72
d10905b
c927b6a
ec26b8d
fc447b5
39cf165
743eeb1
a6b2931
57a5499
d44464b
c36127a
f017063
17410f5
3ac0bb0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why doesn't take this into account whether the attribute is actually applicable and would have an effect? That makes it far less useful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that the current design is the same as
spellcheck
andautocapitalize
, and avoids exposing privacy-sensitive information about user preferences.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't suggesting exposing user preferences though. Mainly that we wouldn't return true for
<input type=date>
or<input disabled>
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even in that respect we're following the precedent for
spellcheck
here, which returnstrue
even for element types that the spec says it can never apply to. The conditions underUser agents must only consider the following pieces of text as checkable...
do not affect the value of thespellcheck
attribute.A practical reason not to do this is that different UAs may make different decisions about where to support writing suggestions, e.g. some may support them in
input type="text"
elements and some may not. Either behavior is allowed per spec, and we don't want to expose these specific choices for the aforementioned privacy/fingerprinting reasons. So if developers get in the habit of checkingwritingSuggestions
on different element types to see where it is supported, they could get the wrong idea about where a particular UA will end up providing writing suggestions.