-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upstream IDL changes from Trusted Types #10199
Conversation
309d8b4
to
496dd6c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inside an IDL block we use <span>
to reference code constructs, not <code>
. Looks mostly good otherwise.
496dd6c
to
59df532
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dontcallmedom do you foresee this causing any issues for the various IDL tools?
none that I can see |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think incremental upstreaming is OK. Are the open threads above resolved? |
Yeah apologies forgot to close them. |
is there a preference for what the commit message should say? And is there anything else that I need to do? |
and maybe repost #10199 (comment) there, since it's the tracking issue for upstreaming. |
ae150e6
to
8a2505f
Compare
Have changed the commit message and reposted that comment |
(See WHATWG Working Mode: Changes for more details.)
/dom.html ( diff )
/dynamic-markup-insertion.html ( diff )
/iframe-embed-object.html ( diff )
/infrastructure.html ( diff )
/references.html ( diff )
/workers.html ( diff )