-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editorial: Upstream outerHTML property from DOM Parsing #10270
Conversation
034bf04
to
7d2d76e
Compare
16281f7
to
59444fb
Compare
59444fb
to
a7625b8
Compare
cc @domenic just as an fyi this one should be ready to go. But no worries if you don't have review capacity for it :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excited to help finish the job!
I just realized I gave bad advice on creating the body element and appending it. Because appending the node will move it away from wherever it was originally. That's no good! We may want to just revert to the fictitious node thing and fix it later. But I dug a bit deeper into how we could make this work. If you're up for it... For HTML, we basically need step 5.2 "Element" case of For XML, I think we use https://w3c.github.io/DOM-Parsing/#dfn-xml-serializing-an-element-node . Although I guess there's some state that is set up in https://w3c.github.io/DOM-Parsing/#dfn-xml-serialization and is normally implicitly passed, which would need to be passed through? (Also I just realized that |
I think our best bet here is to revert to the fictious node for now, and then once more of DOM Parsing is upstreamed (working on insertAdjacentHTML next) we can go through and see how much we can consolidate and abstract between the HTML algorithms and the DOM Parsing ones. |
@domenic this should be done now. As I say I think once have more of the DOM Parsing spec in html we'll have a bigger picture on the best way to improve things. |
fb8fa46
to
3692ea5
Compare
This has been moved to the HTML Standard in whatwg/html#10270.
Follow up to #10264
Corresponding DOM Parsing spec PR: w3c/DOM-Parsing#80
/dynamic-markup-insertion.html ( diff )
/index.html ( diff )
/infrastructure.html ( diff )
/scripting.html ( diff )