Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap "activate view transition" with script prepare/clean up #10284

Merged
merged 4 commits into from
Jul 12, 2024

Conversation

noamr
Copy link
Contributor

@noamr noamr commented Apr 18, 2024

This ensures that we perform a microtask checkpoint (and set the incumbent script) right after resolving/rejecting the ViewTransition promises.

It's necessary as those promises need to be resolved before the other rendering operations, mainly style/layout.

(See WHATWG Working Mode: Changes for more details.)


/browsing-the-web.html ( diff )

This ensures that we perform a microtask checkpoint (and set the incumbent script)
right after resolving/rejecting the `ViewTransition` promises.

It's necessary as those promises need to be resolved before the other
rendering operations, mainly style/layout.
source Show resolved Hide resolved
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Editorial nits, content LGTM. Please also fill out the issue template appropriately.

source Show resolved Hide resolved
source Show resolved Hide resolved
@khushalsagar
Copy link
Contributor

Thanks. LGTM!

@noamr
Copy link
Contributor Author

noamr commented Jul 11, 2024

@domenic I applied the nit suggestions and also filled in the boxes. Ready to merge?

@domenic domenic merged commit f2c7875 into whatwg:main Jul 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants