Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream Trusted Types protection of timer functions #10348

Merged
merged 4 commits into from
Jun 3, 2024

Conversation

lukewarlow
Copy link
Member

@lukewarlow lukewarlow commented May 14, 2024

(See WHATWG Working Mode: Changes for more details.)


/infrastructure.html ( diff )
/timers-and-user-prompts.html ( diff )
/webappapis.html ( diff )

source Outdated Show resolved Hide resolved
@lukewarlow lukewarlow requested a review from zcorpan May 21, 2024 11:44
@zcorpan
Copy link
Member

zcorpan commented May 31, 2024

Looks good, but needs a rebase.

source Outdated Show resolved Hide resolved
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good modulo nit.

(I wasn't able to review wrapping on this machine as the screen width is too narrow.)

<var>repeat</var> is true; "<code data-x="">setTimeout</code>" otherwise.</p></li>

<li><p>Let <var>sink</var> be a concatenation of <var>globalName</var>,
"<code data-x=""> </code>", and <var>methodName</var>.</p></li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"<code data-x=""> </code>", and <var>methodName</var>.</p></li>
U+0020 SPACE, and <var>methodName</var>.</p></li>

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I chucked it through https://domenic.github.io/rewrapper/ so hopefully it's correct

@annevk annevk merged commit 4dc04bc into whatwg:main Jun 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants