-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upstream Trusted Types protection of timer functions #10348
Conversation
9f3a6a6
to
8c6360d
Compare
Looks good, but needs a rebase. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good modulo nit.
(I wasn't able to review wrapping on this machine as the screen width is too narrow.)
<var>repeat</var> is true; "<code data-x="">setTimeout</code>" otherwise.</p></li> | ||
|
||
<li><p>Let <var>sink</var> be a concatenation of <var>globalName</var>, | ||
"<code data-x=""> </code>", and <var>methodName</var>.</p></li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"<code data-x=""> </code>", and <var>methodName</var>.</p></li> | |
U+0020 SPACE, and <var>methodName</var>.</p></li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I chucked it through https://domenic.github.io/rewrapper/ so hopefully it's correct
(See WHATWG Working Mode: Changes for more details.)
/infrastructure.html ( diff )
/timers-and-user-prompts.html ( diff )
/webappapis.html ( diff )