-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge the two table cell interfaces back together #1125
Conversation
Did table sorting introduce the split? It seems to me it was introduced earlier, to deal with the semantic differences. |
readonly attribute long <span data-x="dom-tdth-cellIndex">cellIndex</span>; | ||
|
||
[<span>CEReactions</span>] attribute DOMString <span data-x="dom-th-scope">scope</span>; // only used for th elements | ||
[<span>CEReactions</span>] attribute DOMString <span data-x="dom-th-abbr">abbr</span>; // only used for th elements |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should say "only conforming" since they'll work either way. @zcorpan might want to take a look too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with "only conforming"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't sure conforming was relevant to IDL attributes but works for me
I should probably check with history but my recollection is that it was introduced so that you could add table sorting-specific methods and attributes to |
Nope, see 6db0d8d (modifies |
7424da0 has something to do with it, but it seems it started before that and I can't find when. |
7b879a5
to
e383ae2
Compare
Ever since the dawn of HTML (2ac31bb), there have been two table cell interfaces, HTMLTableDataCellElement for <td>, and HTMLTableHeaderCellElement for <th>. No browser ever implemented this split, instead using the single HTMLTableCellElement interface. This aligns the spec with browser reality. Fixes #1115.
Updated commit message and changed to "only conforming"; please take a look. |
Nice, LGTM. |
Ever since table sorting was introduced, HTMLTableCellElement was split
into two descendant interfaces, HTMLTableDataCellElement for
<td>
, andHTMLTableHeaderCellElement for
<th>
. No browser ever implemented thissplit. Although table sorting was removed in
59b7e24,
the split remained; we now remove it, fixing #1115.