Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and expand incumbent settings object definition #1189

Merged
merged 2 commits into from
Jun 15, 2016
Merged

Fix and expand incumbent settings object definition #1189

merged 2 commits into from
Jun 15, 2016

Commits on Jun 14, 2016

  1. Fix and incumbent settings object definition and add examples 

    As discussed in #473, starting especially from around
#473 (comment), the
definition of incumbent introduced in #401 falls down in certain
important cases. In order to fix this, we introduce several new
concepts, which takes care of these trickier examples. These examples
are now included in the spec, and spell out exactly how exactly
incumbent settings object calculation works in increasingly-complex
scenarios.

The new algorithms "prepare to run a callback" and "clean up after
running a callback" will be used by Web IDL, similarly to how it already
uses "prepare to run script" and "clean up after running script."

Another notable change is that EnqueueJob now correctly tracks the
necessary goings-on in order to make the incumbent settings object work
correctly when promises are used to schedule callbacks.
    @domenic
    domenic committed Jun 14, 2016
    Configuration menu
    Copy the full SHA
    33106f9 View commit details
    Browse the repository at this point in the history

  2. Be more vague about EnqueueJob

    @domenic
    domenic committed Jun 14, 2016
    Configuration menu
    Copy the full SHA
    9c25103 View commit details
    Browse the repository at this point in the history