Use USVString for all URLs #1282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This finds all instances where URLs are part of an IDL interface, including where they are reflecting content attributes, and changes the type from DOMString to USVString. This has already been done in some places in a haphazard way, but this commit finishes the process. This allows us to clarify the rules for reflecting USVString attributes, and remove the clause that allows DOMString attributes to reflect URLs. Fixes #1254. Fixes #1266.
|
Changes LGTM. Will merge later today in case anyone else wants to have a look. |
| @@ -24497,7 +24500,7 @@ was an English <a href="/wiki/Music_hall">music hall</a> singer, ...</pre> | |||
| <dt><span data-x="concept-element-dom">DOM interface</span>:</dt> | |||
| <dd> | |||
| <pre class="idl">interface <dfn>HTMLSourceElement</dfn> : <span>HTMLElement</span> { | |||
| [<span>CEReactions</span>] attribute DOMString <span data-x="dom-source-src">src</span>; | |||
| [<span>CEReactions</span>] attribute USVString <span data-x="dom-source-src">src</span>; | |||
| [<span>CEReactions</span>] attribute DOMString <span data-x="dom-source-type">type</span>; | |||
| [<span>CEReactions</span>] attribute DOMString <span data-x="dom-source-srcset">srcset</span>; | |||
|
Edit: Sorry, there's already a catch-all for USVString. Ignore the above. |
|
Missing the constructors for Worker and SharedWorker |
|
Pushed a fixup. |
|
I also pushed a fixup with a bunch more. |
| @@ -87017,15 +87017,15 @@ interface <dfn>NavigatorOnLine</dfn> { | |||
| <pre class="idl">[Constructor(DOMString type, optional <span>ErrorEventInit</span> eventInitDict), Exposed=(Window,Worker)] | |||
| interface <dfn>ErrorEvent</dfn> : <span>Event</span> { | |||
| readonly attribute DOMString <span data-x="dom-ErrorEvent-message">message</span>; | |||
| readonly attribute DOMString <span data-x="dom-ErrorEvent-filename">filename</span>; | |||
| readonly attribute USVString <span data-x="dom-ErrorEvent-filename">filename</span>; | |||
There was a problem hiding this comment.
https://html.spec.whatwg.org/multipage/webappapis.html#runtime-script-errors
Let location be an absolute URL that corresponds to the resource from which script was obtained.
...
Initialise event's filename attribute to location.
|
OK I think I'm done here. |
|
Looks good, will let @domenic land. |
|
Great catches, thanks; can't believe I missed them. |
SimonSapin
added a commit
to SimonSapin/csswg-drafts
that referenced
this pull request
Apr 21, 2017
As resolved by CSS WG on 2017-04-19, because they are URLs. This is consistent with HTML: whatwg/html#1282
zcorpan
pushed a commit
to w3c/csswg-drafts
that referenced
this pull request
Apr 21, 2017
As resolved by CSS WG on 2017-04-19, because they are URLs. This is consistent with HTML: whatwg/html#1282
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This finds all instances where URLs are part of an IDL interface,
including where they are reflecting content attributes, and changes the
type from DOMString to USVString. This has already been done in some
places in a haphazard way, but this commit finishes the process.
This allows us to clarify the rules for reflecting USVString attributes,
and remove the clause that allows DOMString attributes to reflect URLs.
Fixes #1254. Fixes #1266.
/cc @Ms2ger