Remove the context menu feature #2742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature sadly never garnered enough implementation interest, being only implemented in Gecko. For some time it looked as though Blink was also interested in implementing, but they recently made the decision to cease implementation and remove all of their code for it, per https://bugs.chromium.org/p/chromium/issues/detail?id=87553&desc=2#c64. Closes #2730.
domenic
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Jun 6, 2017
|
Allowing only |
Also move keygen before listing.
zcorpan
added
document conformance
normative change
removal/deprecation
|
Thanks for the additional finds and fixes; they all look good. I'll add some tests for the UA stylesheet. |
Agreed, for that kind of reason it make sense to restrict it to allowing only |
|
It would be nice to hear something from Mozilla folks before merging this. If they decide to keep the feature I suppose they want to have the tests in some non-wpt location or so. @jgraham? |
|
I meant that for web-platform-tests/wpt#6167 |
zcorpan
approved these changes
Jun 8, 2017
domenic
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Jun 8, 2017
sideshowbarker
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jun 8, 2017
Remove tests for, and test the removal of, context menus Follows whatwg/html#2742. Also test computed style (i.e. UA stylesheet)
sideshowbarker
pushed a commit
to validator/tests
that referenced
this pull request
Jun 24, 2017
Remove tests for, and test the removal of, context menus Follows whatwg/html#2742. Also test computed style (i.e. UA stylesheet)
sideshowbarker
added a commit
to validator/validator
that referenced
this pull request
Jun 25, 2017
This change disallows the "contextmenu" attribute and type=contextmenu and type=toolbar for the `menu` element. See whatwg/html#2742 Fixes #526
|
Interestingly, we're considering to implement this feature in https://bugs.webkit.org/show_bug.cgi?id=179020. |
jugglinmike
added a commit
to bocoup/html-aam
that referenced
this pull request
Sep 6, 2019
In 2015, the "popup" value of the `<menu>` element's `type` attribute was renamed to "context" [1]. In 2017, the `<menuitem>` element and the `type` attribute of the `<menu>` element were removed entirely [2]. Remove the rows that describe these features. [1] whatwg/html#241 [2] whatwg/html#2742
jugglinmike
added a commit
to bocoup/html-aam
that referenced
this pull request
Sep 7, 2019
In 2015, the "popup" value of the `<menu>` element's `type` attribute was renamed to "context" [1]. In 2017, the `<menuitem>` element and the `type` attribute of the `<menu>` element were removed entirely [2]. Remove the rows that describe these features. [1] whatwg/html#241 [2] whatwg/html#2742
5 tasks
andreubotella
added a commit
to andreubotella/pointerevents
that referenced
this pull request
Jan 19, 2022
The reference to the `contextmenu` event in 4.2.12 links to the HTML spec, even though any non-editorial mentions of that event –but not the definition in the event list– were removed (apparently by mistake) in whatwg/html#2742. That event was subsequently added to the UI Events spec in w3c/uievents#279, and now the definition in the HTML spec's event list has been removed in whatwg/html#7506. This change updates the reference to link to the UI Events spec.
patrickhlauke
pushed a commit
to w3c/pointerevents
that referenced
this pull request
Jan 19, 2022
The reference to the `contextmenu` event in 4.2.12 links to the HTML spec, even though any non-editorial mentions of that event –but not the definition in the event list– were removed (apparently by mistake) in whatwg/html#2742. That event was subsequently added to the UI Events spec in w3c/uievents#279, and now the definition in the HTML spec's event list has been removed in whatwg/html#7506. This change updates the reference to link to the UI Events spec.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature sadly never garnered enough implementation interest, being
only implemented in Gecko. For some time it looked as though Blink was
also interested in implementing, but they recently made the decision to
cease implementation and remove all of their code for it, per
https://bugs.chromium.org/p/chromium/issues/detail?id=87553&desc=2#c64.
Closes #2730.
Tests: web-platform-tests/wpt#6167
@sideshowbarker, @zcorpan, any thoughts on whether
<menu>should be simplified further to only allow<li>s, like<ul>? Or should we keep it as allowing either<li>s or "if the element has no li element children, flow content describing available commands"?