Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More accurate wording in the document semantics section #2790

Closed
wants to merge 1 commit into from

Conversation

harttle
Copy link
Contributor

@harttle harttle commented Jun 25, 2017

https://html.spec.whatwg.org/#html-element-constructors

Since there can be no entry in registry with a constructor of undefined, this step also prevents...

Custom Element definition must throw when constructor is undefined, so there should be actually no entry in registry with a constructor of undefined.

@domenic
Copy link
Member

domenic commented Jun 25, 2017

Hmm, both wordings seem correct, but "can be" seems more like it's describing what's going on. There can be no entry, because it was prohibited earlier.

domenic added a commit that referenced this pull request Jun 28, 2017
Closes #2790.
@domenic domenic mentioned this pull request Jun 28, 2017
@domenic
Copy link
Member

domenic commented Jun 28, 2017

I've posted #2798 to correct the typo you noticed without changing any of the meaning; let me know what you think.

domenic added a commit that referenced this pull request Jun 28, 2017
@harttle
Copy link
Contributor Author

harttle commented Jun 29, 2017

Looks good. It seems better to say "the whole page". The "can be no" statement is correct, my fault.

alice pushed a commit to alice/html that referenced this pull request Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants