Add customElements.upgrade() #3535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenic
added
addition/proposal
domenic
removed
the
needs tests
tkent-google
reviewed
Mar 7, 2018
source
Outdated
|
|
||
| <ol> | ||
| <li><p>Let <var>candidates</var> be a <span>list</span> of all of <var>root</var>'s | ||
| <span data-x="inclusive descendant">inclusive descendants</span>, in <span>tree order</span>, |
There was a problem hiding this comment.
It's not "shadow-including inclusive descendant" intentionally?
There was a problem hiding this comment.
Good question! We did not think about it in any previous discussions. But I think it should be shadow-including to be consistent with the normal upgrades when you connect to the main document---those use "connected", not "in a document tree".
I will fix and add more tests.
|
Updated the spec and tests to be shadow-including! |
annevk
approved these changes
Mar 7, 2018
|
(Still needs browser bugs.) |
|
Browser bugs:
(None for Edge as they are still in the very initial stages of custom elements so this will come as they work on the spec.) |
|
LGTM |
tkent-google
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Mar 7, 2018
* Add tests for customElements.upgrade() Follows whatwg/html#3535. * Fix one test; test that it's shadow-including descendants
29 tasks
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Apr 1, 2018
…=testonly Automatic update from web-platform-testsAdd tests for customElements.upgrade() (#9869) * Add tests for customElements.upgrade() Follows whatwg/html#3535. * Fix one test; test that it's shadow-including descendants wpt-commits: e3b651475426769bba0f043fd53e11a9c4ef93d5 wpt-pr: 9869 wpt-commits: e3b651475426769bba0f043fd53e11a9c4ef93d5 wpt-pr: 9869
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 2, 2019
…=testonly Automatic update from web-platform-testsAdd tests for customElements.upgrade() (#9869) * Add tests for customElements.upgrade() Follows whatwg/html#3535. * Fix one test; test that it's shadow-including descendants wpt-commits: e3b651475426769bba0f043fd53e11a9c4ef93d5 wpt-pr: 9869 wpt-commits: e3b651475426769bba0f043fd53e11a9c4ef93d5 wpt-pr: 9869 UltraBlame original commit: ce9bf92f06c09e01e0f52048e8e6d1602357342d
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 2, 2019
…=testonly Automatic update from web-platform-testsAdd tests for customElements.upgrade() (#9869) * Add tests for customElements.upgrade() Follows whatwg/html#3535. * Fix one test; test that it's shadow-including descendants wpt-commits: e3b651475426769bba0f043fd53e11a9c4ef93d5 wpt-pr: 9869 wpt-commits: e3b651475426769bba0f043fd53e11a9c4ef93d5 wpt-pr: 9869 UltraBlame original commit: ce9bf92f06c09e01e0f52048e8e6d1602357342d
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 2, 2019
…=testonly Automatic update from web-platform-testsAdd tests for customElements.upgrade() (#9869) * Add tests for customElements.upgrade() Follows whatwg/html#3535. * Fix one test; test that it's shadow-including descendants wpt-commits: e3b651475426769bba0f043fd53e11a9c4ef93d5 wpt-pr: 9869 wpt-commits: e3b651475426769bba0f043fd53e11a9c4ef93d5 wpt-pr: 9869 UltraBlame original commit: ce9bf92f06c09e01e0f52048e8e6d1602357342d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes WICG/webcomponents#710.
@tkent-google and @rniwa might be interested in reviewing. /cc @whatwg/components
Tests: web-platform-tests/wpt#9869
/custom-elements.html ( diff )
/infrastructure.html ( diff )