Remove showModalDialog() #374
Conversation
|
Changes LGTM. None of the definitions are used elsewhere. The spec has the same pausing concept for both Firefox hasn't removed it yet. https://bugzilla.mozilla.org/show_bug.cgi?id=981796 Why is now a good time to remove it from the spec? |
WebKit has removed it from mobile, which is where the majority of WebKit usage is.
Simply because I actually got around to making the pull request :). I think a feature that is in only 1.5 browsers and everyone agrees is deprecated should probably be removed, right? |
domenic
force-pushed
the
rm-showmodaldialog
branch
from
876b493
to
ce95196
Compare
|
It was never in mobile Safari to begin with, I believe. Can you file a bug or something for WebKit? |
|
WebKit bug filed https://bugs.webkit.org/show_bug.cgi?id=151885 /cc @hober @rniwa |
|
Thanks. I suppose Mozilla is OK with removing If nobody has objected by, I dunno, mid-January 2016, I suggest we merge this. |
|
I do not represent either of Mozilla's browser teams on this (or anything, really). |
|
LGTM. It's clear this is not going to be kept around much longer. Desktop Firefox and Safari don't have that power. (It does seem they might want to implement |
|
(Somewhat sad that removing this doesn't allow us to remove nested event loops. What else is blocking that?) |
|
I wasn't able to really find how "nested event loops" manifest in the spec. |
|
Seems like that is "spin the event loop" which is used by a number of things (though not all of them manifest in nested event loops I suppose). |
annevk
force-pushed
the
rm-showmodaldialog
branch
from
ce95196
to
eec9646
Compare
|
We want to remove See https://bugzilla.mozilla.org/show_bug.cgi?id=1206885 (which is about attachments not working in Outlook Web App 2010). A quick google search will find you countless people complaining about OWA attachments not working in Edge or Chrome (with some people suggesting using Firefox as a workaround, or to install Silverlight :/): http://answers.microsoft.com/en-us/windows/forum/apps_windows_10-msedge/outlook-web-access-owa-problems-in-edge/1de9d78d-dba0-46cb-9654-be7fd985b57f?page=5
@domenic I can't find the comment now, but I read in a Chromium bug that Outlook and Google were in communication about the issue, would you happen to know if there was a resolution? @jacobrossi does Microsoft have a plan for this? It feels wrong to remove this and break this many sites, is there something crazy we can do like shim |
|
We deprecated it a long while back. Edge does not have this API. It is still in IE and will remain there given lots of line of business apps designed for IE require it. |
Right, I link to some forums above of people complaining about OWA 2010 not working in Edge. :/ |
|
@miketaylr correct, which is why we recommend IE for legacy enterprise applications on Windows 10 and provide a way to jump from Edge to IE for those legacy apps. Historically, providing updates to old versions of OWA (pre-Office365 service based model) doesn't help in these situations because of on-prem installations that we don't manage. Moreover, on-prem installations typically don't show up in things like crawler statistics or UseCounters (IT Policies often disables this collection), so we also can't reliably determine when usage is sufficiently low. Hence, we freeze IE where it's at for these customers that still require legacy APIs while moving Edge ahead into the modern web without this cruft. |
I don't think so. Often the blocking behavior is needed, and you can't polyfill that without changing the client code, so filling this gap needs to happen in the apps that need it, I believe. Trying to polyfill it in the browser would probably cause more trouble. |
I mean, depends on what you mean by web-compatible. At this point it's basically a Firefox-only feature (and Safari desktop). So it's not really part of the web, just the Firefox web.
@jeisinger might know more. My understanding is that the latest versions of OWA do not use showModalDialog. |
Correct |
|
yes |
Well, Firefox (for now anyways) and Safari and IE. Just not Blink browsers or Edge. I'm not sure how that makes it not part of the web (even if it's really gross). It just feels weird to break the presumably thousands of OWA 2010 installations out there with the recommendation to stay on legacy IE browsers (or Safari, I guess) if you want to keep using your webmail. |
|
The recommendation is to upgrade to a supported version of exchange... |
Yes, that's the right recommendation for the site owners. Unfortunately software upgrades are more frequently business decisions than technical ones. I don't suspect anybody has teams doing evangelism for these sites (and my small team doesn't have the bandwidth). (And generally the people in charge of these types of things aren't reading deprecation articles on Dev Opera or anywhere else.) For the people commenting in Chromium bugs and in Microsoft forums (and in Bugzilla for e10s users), the recommendation is currently is "try another browser". |
|
@miketaylr note that removal from the HTML standard does not mean that Firefox e10s cannot implement this. It just means that the authors of the HTML standard agreed that there's no future for this feature. If Edge, Chrome, mobile Safari, Firefox e10s, all feel compelled to add this again, we'll obviously reconsider, but it seems far more likely that in a couple of years nobody has this anymore (except perhaps desktop Safari, their feature removal process seems extremely conservative). |
|
FYI, Exchange 2010 is still supported and they released an update rollup to fix this long ago. |
These were added in commit 818bcab and reflect the structure of the HTML spec as it was in 2012. The structure largely remains the same, but some directories like webappapis/user-prompts/dialogs-implemented-using-separate-documents/ are gone from the spec (whatwg/html#374) and others like introduction/ are non-normative and should never be populated. But mainly, a lot of empty directories is a nuisance when exploring the directory in a file manager or on GitHub. The number of directories in 2dcontext/ and html/ combined decreases by almost 200, from 653 to 456.
These were added in commit 818bcab and reflect the structure of the HTML spec as it was in 2012. The structure largely remains the same, but some directories like webappapis/user-prompts/dialogs-implemented-using-separate-documents/ are gone from the spec (whatwg/html#374) and others like introduction/ are non-normative and should never be populated. But mainly, a lot of empty directories is a nuisance when exploring the directory in a file manager or on GitHub. The number of directories in 2dcontext/ and html/ combined decreases by almost 200, from 653 to 456.
…html/, a=testonly Automatic update from web-platform-testsRemove .gitkeep files in 2dcontext/ and html/ (#11851) These were added in commit 818bcab4ba58d2bc8dba94276c8b944c76570a19 and reflect the structure of the HTML spec as it was in 2012. The structure largely remains the same, but some directories like webappapis/user-prompts/dialogs-implemented-using-separate-documents/ are gone from the spec (whatwg/html#374) and others like introduction/ are non-normative and should never be populated. But mainly, a lot of empty directories is a nuisance when exploring the directory in a file manager or on GitHub. The number of directories in 2dcontext/ and html/ combined decreases by almost 200, from 653 to 456. -- wpt-commits: ddfe9c089bab565a9d3aa37bdef63d8012c1a94c wpt-pr: 11851
…html/, a=testonly Automatic update from web-platform-testsRemove .gitkeep files in 2dcontext/ and html/ (#11851) These were added in commit 818bcab4ba58d2bc8dba94276c8b944c76570a19 and reflect the structure of the HTML spec as it was in 2012. The structure largely remains the same, but some directories like webappapis/user-prompts/dialogs-implemented-using-separate-documents/ are gone from the spec (whatwg/html#374) and others like introduction/ are non-normative and should never be populated. But mainly, a lot of empty directories is a nuisance when exploring the directory in a file manager or on GitHub. The number of directories in 2dcontext/ and html/ combined decreases by almost 200, from 653 to 456. -- wpt-commits: ddfe9c089bab565a9d3aa37bdef63d8012c1a94c wpt-pr: 11851
…html/, a=testonly Automatic update from web-platform-testsRemove .gitkeep files in 2dcontext/ and html/ (#11851) These were added in commit 818bcab4ba58d2bc8dba94276c8b944c76570a19 and reflect the structure of the HTML spec as it was in 2012. The structure largely remains the same, but some directories like webappapis/user-prompts/dialogs-implemented-using-separate-documents/ are gone from the spec (whatwg/html#374) and others like introduction/ are non-normative and should never be populated. But mainly, a lot of empty directories is a nuisance when exploring the directory in a file manager or on GitHub. The number of directories in 2dcontext/ and html/ combined decreases by almost 200, from 653 to 456. -- wpt-commits: ddfe9c089bab565a9d3aa37bdef63d8012c1a94c wpt-pr: 11851 UltraBlame original commit: 9a8d6a00920ec6fb7cb3dae6074ea4e26aaf5744
…html/, a=testonly Automatic update from web-platform-testsRemove .gitkeep files in 2dcontext/ and html/ (#11851) These were added in commit 818bcab4ba58d2bc8dba94276c8b944c76570a19 and reflect the structure of the HTML spec as it was in 2012. The structure largely remains the same, but some directories like webappapis/user-prompts/dialogs-implemented-using-separate-documents/ are gone from the spec (whatwg/html#374) and others like introduction/ are non-normative and should never be populated. But mainly, a lot of empty directories is a nuisance when exploring the directory in a file manager or on GitHub. The number of directories in 2dcontext/ and html/ combined decreases by almost 200, from 653 to 456. -- wpt-commits: ddfe9c089bab565a9d3aa37bdef63d8012c1a94c wpt-pr: 11851 UltraBlame original commit: 9a8d6a00920ec6fb7cb3dae6074ea4e26aaf5744
…html/, a=testonly Automatic update from web-platform-testsRemove .gitkeep files in 2dcontext/ and html/ (#11851) These were added in commit 818bcab4ba58d2bc8dba94276c8b944c76570a19 and reflect the structure of the HTML spec as it was in 2012. The structure largely remains the same, but some directories like webappapis/user-prompts/dialogs-implemented-using-separate-documents/ are gone from the spec (whatwg/html#374) and others like introduction/ are non-normative and should never be populated. But mainly, a lot of empty directories is a nuisance when exploring the directory in a file manager or on GitHub. The number of directories in 2dcontext/ and html/ combined decreases by almost 200, from 653 to 456. -- wpt-commits: ddfe9c089bab565a9d3aa37bdef63d8012c1a94c wpt-pr: 11851 UltraBlame original commit: 9a8d6a00920ec6fb7cb3dae6074ea4e26aaf5744
Fixes https://www.w3.org/Bugs/Public/show_bug.cgi?id=26437.
A surprisingly clean cut. I was hoping there would be more stuff we could simplify by this removal, but it all seems contained within that section. I would love it if someone could prove me wrong.