-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ground custom elements in agents #4204
Conversation
Pending ongoing disagreements in #4198 and whatwg/dom#717, so tagging "do not merge yet". |
ec8864a
to
222ed14
Compare
@domenic I think we reached agreement, can you take a look at the PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but as with the DOM PR would suggest introducing a shorthand.
These would improve whatwg/dom#717 and #4204.
These would improve whatwg/dom#717 and #4204.
222ed14
to
567e543
Compare
This could probably use another look over to be safe. |
<li><p>Let <var>queue</var> be the result of popping the <span>current element queue</span> | ||
from the <span>custom element reactions stack</span>. (This will be the same <span>element | ||
<li><p>Let <var>queue</var> be the result of popping <var>document</var>'s <span>relevant | ||
agent</span>'s <span>current element queue</span>. (This will be the same <span>element |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't pop the queue. You pop from the stack; the result is === the current queue (at least, the current queue before popping). I think just omit mention of the current queue from here, and use "popping from" like above.
These would improve whatwg/dom#717 and whatwg#4204.
These would improve whatwg/dom#717 and whatwg#4204.
The "unit of related similar-origin browsing contexts" concept is inaccurate.
Helps with #4198.
/custom-elements.html ( diff )
/parsing.html ( diff )