Add multiplied-out coordinates for canvas transforms #4473
Conversation
There was a problem hiding this comment.
I guess the question is if this matches implementations. https://twitter.com/pcwalton/status/1111309241418014720 makes me nervous, but I also don't know this space well enough.
|
Glad you made me check. Apparently the default z coordinate is 1, not 0, so https://www.wolframalpha.com/input/?i=%7B%7Ba,+c,+e%7D,+%7Bb,+d,+f%7D,+%7B0,+0,+1%7D%7D+.+%7B%7Bx%7D,+%7By%7D,+%7B1%7D%7D is more correct. This matches https://developer.mozilla.org/en-US/docs/Web/API/CanvasRenderingContext2D/transform . Things seem interoperable. Test with https://jsbin.com/nanicuwebi/1/edit?html,output or https://github.com/web-platform-tests/wpt/blob/master/2dcontext/transformations/2d.transformation.transform.skewed.html |
|
Ping |
|
Sorry, I was hoping someone else would be able to review this, but I should have indicated that more clearly. @fserb perhaps? |
|
this makes sense to me. My only question is if the notes should have the |
There was a problem hiding this comment.
@fserb I wouldn't mind consistent multiplication symbols (or lack thereof) going forward, but it'd be good to ground that somehow across graphics-related standards so we don't each use our own rules. If you were willing to take that on that'd be great. In any event I'll leave this up to @domenic for now given that in principle everything here is in order.
Closes https://www.w3.org/Bugs/Public/show_bug.cgi?id=28333. https://www.wolframalpha.com/input/?i=%7B%7Ba,+c,+e%7D,+%7Bb,+d,+f%7D,+%7B0,+0,+1%7D%7D+.+%7B%7Bx%7D,+%7By%7D,+%7B0%7D%7D if you want to check my work.
/acknowledgements.html ( diff )
/browsers.html ( diff )
/browsing-the-web.html ( diff )
/canvas.html ( diff )
/common-dom-interfaces.html ( diff )
/common-microsyntaxes.html ( diff )
/comms.html ( diff )
/custom-elements.html ( diff )
/dnd.html ( diff )
/dom.html ( diff )
/dynamic-markup-insertion.html ( diff )
/edits.html ( diff )
/embedded-content-other.html ( diff )
/embedded-content.html ( diff )
/form-control-infrastructure.html ( diff )
/form-elements.html ( diff )
/forms.html ( diff )
/grouping-content.html ( diff )
/history.html ( diff )
/iana.html ( diff )
/iframe-embed-object.html ( diff )
/image-maps.html ( diff )
/imagebitmap-and-animations.html ( diff )
/images.html ( diff )
/index.html ( diff )
/indices.html ( diff )
/infrastructure.html ( diff )
/input.html ( diff )
/interaction.html ( diff )
/interactive-elements.html ( diff )
/introduction.html ( diff )
/links.html ( diff )
/media.html ( diff )
/microdata.html ( diff )
/named-characters.html ( diff )
/obsolete.html ( diff )
/offline.html ( diff )
/origin.html ( diff )
/parsing.html ( diff )
/references.html ( diff )
/rendering.html ( diff )
/scripting.html ( diff )
/sections.html ( diff )
/semantics-other.html ( diff )
/semantics.html ( diff )
/server-sent-events.html ( diff )
/structured-data.html ( diff )
/syntax.html ( diff )
/system-state.html ( diff )
/tables.html ( diff )
/text-level-semantics.html ( diff )
/timers-and-user-prompts.html ( diff )
/urls-and-fetching.html ( diff )
/web-messaging.html ( diff )
/web-sockets.html ( diff )
/webappapis.html ( diff )
/webstorage.html ( diff )
/window-object.html ( diff )
/workers.html ( diff )
/xhtml.html ( diff )