Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore document.open/write after the active parser has been aborted #4907

Merged
merged 3 commits into from
Oct 16, 2019

Conversation

foolip
Copy link
Member

@foolip foolip commented Sep 12, 2019

source Show resolved Hide resolved
source Show resolved Hide resolved
source Show resolved Hide resolved
@annevk annevk requested a review from bzbarsky September 25, 2019 14:07
Copy link
Contributor

@bzbarsky bzbarsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Thank you for putting it together, and my apologies for the horrible review lag...

@bzbarsky
Copy link
Contributor

@rniwa Do you know who on the WebKit side should take a look at this?

@domenic domenic merged commit ead4aa8 into master Oct 16, 2019
@domenic domenic deleted the foolip/ignore-opens-and-writes branch October 16, 2019 08:25
@domenic
Copy link
Member

domenic commented Oct 16, 2019

I filed a WebKit bug at https://bugs.webkit.org/show_bug.cgi?id=203028 (also in the OP with the Gecko and Blink bugs)

@cdumez
Copy link

cdumez commented Oct 16, 2019

Are there WPT tests for this?

@jdm
Copy link
Member

jdm commented Oct 16, 2019

web-platform-tests/wpt#19732

yury-s pushed a commit to yury-s/webkit-http that referenced this pull request Oct 23, 2019
https://bugs.webkit.org/show_bug.cgi?id=203028

Reviewed by Geoffrey Garen.

LayoutTests/imported/w3c:

Rebaseline WPT test that is now passing.

* web-platform-tests/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/aborted-parser.window-expected.txt:

Source/WebCore:

Ignore document.open/write after the active parser has been aborted, as per:
- whatwg/html#4907

Test: imported/blink/fast/loader/document-write-after-location-change.html

* dom/Document.cpp:
(WebCore::Document::open):
(WebCore::Document::cancelParsing):
(WebCore::Document::implicitOpen):
(WebCore::Document::write):
* dom/Document.h:

LayoutTests:

Import test from blink.

* imported/blink/fast/loader/document-write-after-location-change-expected.txt: Added.
* imported/blink/fast/loader/document-write-after-location-change.html: Added.
* imported/blink/fast/loader/resources/pass-and-notify-done.html: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@251506 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Consider adding an "ignore document.open/write" flag on document
6 participants