Specify which event loop to use for posting messages #4917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annevk
reviewed
Sep 25, 2019
source
Outdated
| @@ -98334,7 +98334,8 @@ function receiver(e) { | |||
| any exceptions.</p></li> | |||
|
|
|||
| <li> | |||
| <p><span>Queue a task</span> on the <span>posted message task source</span> to run the | |||
| <p><span>Queue a task</span> on the <span>posted message task source</span> of | |||
There was a problem hiding this comment.
Given that we mention it here and this is the only task queueing, we can maybe remove "The task source for the tasks in cross-document messaging is the posted message task source." and inline the <dfn>?
| @@ -99178,7 +99179,8 @@ interface <dfn>BroadcastChannel</dfn> : <span>EventTarget</span> { | |||
|
|
|||
| <li> | |||
| <p>For each <code>BroadcastChannel</code> object <var>destination</var> in | |||
| <var>destinations</var>, <span>queue a task</span> that runs the following steps:</p> | |||
| <var>destinations</var>, <span>queue a task</span> on <var>destination</var>'s <span>relevant | |||
There was a problem hiding this comment.
What task source does this use? (Note that this section is parallel to the one that defines the "posted message task source" and so while that might be a good choice, it doesn't appear in scope.)
There was a problem hiding this comment.
A few lines below it says DOM manipulation task source. I'll inline that in to the call site.
annevk
approved these changes
Sep 27, 2019
This was referenced Apr 13, 2020
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4653.
/web-messaging.html ( diff )