Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forms: Introduce SubmitEvent for 'submit' event #4984

Merged
merged 7 commits into from
Oct 31, 2019

Conversation

tkent-google
Copy link
Contributor

@tkent-google tkent-google commented Oct 8, 2019

source Show resolved Hide resolved
source Show resolved Hide resolved
source Show resolved Hide resolved
@annevk annevk added addition/proposal New features or enhancements topic: forms labels Oct 15, 2019
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the newline this looks good to me and I'm happy to go with this approach after our discussion.

And Firefox would be happy to implement this.

@domenic
Copy link
Member

domenic commented Oct 15, 2019

I'll merge and work on reviewing/merging the tests now. Please don't forget to file implementer bugs, and update the OP when you do.

Yay!!

@annevk
Copy link
Member

annevk commented Oct 15, 2019

Please wait, see WPT discussion.

@domenic
Copy link
Member

domenic commented Oct 15, 2019

Oh, thank you for the quick response!

@tkent-google
Copy link
Contributor Author

Updated the PR so that submitter is nullable.

source Show resolved Hide resolved
@annevk annevk requested a review from domenic October 31, 2019 17:52
@domenic domenic merged commit f476180 into whatwg:master Oct 31, 2019
tkent-google added a commit to web-platform-tests/wpt that referenced this pull request Nov 1, 2019
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Nov 20, 2019
…e, a=testonly

Automatic update from web-platform-tests
html: Add tests for SubmitEvent interface (#19562)

Specification PR: whatwg/html#4984

--

wpt-commits: 61c2804bf27a7abc1b8bc406627f6bf3b3344f14
wpt-pr: 19562

Differential Revision: https://phabricator.services.mozilla.com/D53600
xeonchen pushed a commit to xeonchen/gecko that referenced this pull request Nov 20, 2019
…e, a=testonly

Automatic update from web-platform-tests
html: Add tests for SubmitEvent interface (#19562)

Specification PR: whatwg/html#4984

--

wpt-commits: 61c2804bf27a7abc1b8bc406627f6bf3b3344f14
wpt-pr: 19562

Differential Revision: https://phabricator.services.mozilla.com/D53600
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Nov 21, 2019
…e, a=testonly

Automatic update from web-platform-tests
html: Add tests for SubmitEvent interface (#19562)

Specification PR: whatwg/html#4984

--

wpt-commits: 61c2804bf27a7abc1b8bc406627f6bf3b3344f14
wpt-pr: 19562

Differential Revision: https://phabricator.services.mozilla.com/D53600

UltraBlame original commit: 8e52d11e8347d0a5573b9c349fa15722ef7448b1
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Nov 21, 2019
…e, a=testonly

Automatic update from web-platform-tests
html: Add tests for SubmitEvent interface (#19562)

Specification PR: whatwg/html#4984

--

wpt-commits: 61c2804bf27a7abc1b8bc406627f6bf3b3344f14
wpt-pr: 19562

Differential Revision: https://phabricator.services.mozilla.com/D53600

UltraBlame original commit: 8e52d11e8347d0a5573b9c349fa15722ef7448b1
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Nov 21, 2019
…e, a=testonly

Automatic update from web-platform-tests
html: Add tests for SubmitEvent interface (#19562)

Specification PR: whatwg/html#4984

--

wpt-commits: 61c2804bf27a7abc1b8bc406627f6bf3b3344f14
wpt-pr: 19562

Differential Revision: https://phabricator.services.mozilla.com/D53600

UltraBlame original commit: 8e52d11e8347d0a5573b9c349fa15722ef7448b1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addition/proposal New features or enhancements topic: forms
Development

Successfully merging this pull request may close these issues.

Would be nice if submit events exposed the "submitter" element
3 participants