-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set requests' user activation flag during navigation. #5203
Conversation
In order to support Fetch Metadata's `Sec-Fetch-User` header, this patch sets navigation requests' user activation flag if the navigation is triggered while the source browsing context has transient activation.
(Note that this patch depends on whatwg/fetch#993 landing first.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks accurate. @mustaqahmed want to double check?
This looks good from user activation perspective. Two questions/nits:
|
Thanks, @mustaqahmed (and @domenic for the ping)! I've added the hyphen to WDYT, @annevk? |
Today's commits merge in the last few months of changes, and adjusts the patch to talk about a request's "user activation" boolean, per the rename in whatwg/fetch#993. |
After whatwg/fetch#948, whatwg/fetch#993, and whatwg/html#5203, the integration with Fetch and HTML is complete. This patch points to those integration points rather than claiming that there's still work to be done. Closes #73.
After whatwg/fetch#948, whatwg/fetch#993, and whatwg/html#5203, the integration with Fetch and HTML is complete. This patch points to those integration points rather than claiming that there's still work to be done. Closes #73.
In order to support Fetch Metadata's
Sec-Fetch-User
header, this patchsets navigation requests' user activation flag if the navigation is
triggered while the source browsing context has transient activation.
/browsing-the-web.html ( diff )
/infrastructure.html ( diff )