-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove table sorting model #526
Conversation
6be3442
to
e40d7bc
Compare
@Ritsyy when I run the build script against this patch I get ten errors. I also noted that you remove some examples that include images. We should probably remove the images at the same time. |
e40d7bc
to
4f4767d
Compare
@annevk In this too |
@Ritsyy I still get ten errors when I run the build script. |
07ef488
to
9582600
Compare
@annevk I have committed the changes. |
The wrapping here is wrong:
That can be two lines. The wrapping here is wrong too:
You cannot have a newline/whitespace following a start tag or preceding an end tag (both happen here). Looks good otherwise. |
Maybe we should have a tool to auto-format the spec so we don't have to ask people to learn the style :) |
Related commits to it: whatwg@6db0d8d whatwg@f1b702f whatwg@427c247 whatwg@2699e4a whatwg@776ac74
9582600
to
a2368ca
Compare
@Ritsyy, I see you have fixed @annevk's wrapping issues. I have also reviewed the changes, very nice! Here's how I will change the commit message when merging:
Note the blank line after the first line, and of course the link to the issue. Thanks again! |
@foolip Thank you for the reviews!, will remember this now :) |
Pushed as commit 59b7e24 |
X-Ref: w3c/html#248 |
This was part of a feature long removed from HTML: whatwg/html#526 https://github.com/mdn/browser-compat-data/blob/main/docs/data-guidelines.md#removal-of-irrelevant-features
This was part of a feature long removed from HTML: whatwg/html#526 https://github.com/mdn/browser-compat-data/blob/main/docs/data-guidelines.md#removal-of-irrelevant-features
Fix #345