Don't execute scripts that have moved documents #5575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenic
approved these changes
May 26, 2020
domenic
added
the
do not merge yet
|
+1 on holding off. It could be nice to at least get some UseCounter data at least. |
domfarolino
added a commit
to web-platform-tests/wpt
that referenced
this pull request
May 27, 2020
This PR adds empty-src tests, which moves <script src=""> elements between Documents before #prepare-a-script. If the parser document check is done in #prepare-a-script, the <script>'s error event is not fired, and thus we can more-completely test whether the parser document check is done. This PR also does some minor refactoring / documentation clean-up, as well as adds a TODO to remove some of the tests once whatwg/html#2137 is closed and whatwg/html#5575 lands. Co-authored-by: Dominic Farolino <domfarolino@gmail.com>
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jun 1, 2020
…e in #prepare-a-script, a=testonly Automatic update from web-platform-tests Test whether parse document check is done in #prepare-a-script (#23162) This PR adds empty-src tests, which moves <script src=""> elements between Documents before #prepare-a-script. If the parser document check is done in #prepare-a-script, the <script>'s error event is not fired, and thus we can more-completely test whether the parser document check is done. This PR also does some minor refactoring / documentation clean-up, as well as adds a TODO to remove some of the tests once whatwg/html#2137 is closed and whatwg/html#5575 lands. Co-authored-by: Dominic Farolino <domfarolino@gmail.com> -- wpt-commits: eccee3ede4f1debb1ad5bd34e6122bcb2cadce48 wpt-pr: 23162
xeonchen
pushed a commit
to xeonchen/gecko
that referenced
this pull request
Jun 2, 2020
…e in #prepare-a-script, a=testonly Automatic update from web-platform-tests Test whether parse document check is done in #prepare-a-script (#23162) This PR adds empty-src tests, which moves <script src=""> elements between Documents before #prepare-a-script. If the parser document check is done in #prepare-a-script, the <script>'s error event is not fired, and thus we can more-completely test whether the parser document check is done. This PR also does some minor refactoring / documentation clean-up, as well as adds a TODO to remove some of the tests once whatwg/html#2137 is closed and whatwg/html#5575 lands. Co-authored-by: Dominic Farolino <domfarolino@gmail.com> -- wpt-commits: eccee3ede4f1debb1ad5bd34e6122bcb2cadce48 wpt-pr: 23162
domenic
removed
the
do not merge yet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The actual spec change is somewhat editorial, since we're just locking in the current spec behavior, but I'm including the below for further documentation / justification.
Assuming we're comfortable closing #2137 in favor of locking in the current spec, which I believe is tested by web-platform-tests/wpt#19632, this small PR should be the last thing left.
/scripting.html ( diff )