Use dotted intrinsic form from ecma262 #5655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the ecma262 spec, we've added a [new intrinsic notation form](tc39/ecma262#1376) that will avoid unbounded growth of our list of intrinsics. Specifically, things like `%ArrayPrototype%` and `%ObjProto_valueOf%` should now be represented as `%Array.prototype%` and `%Object.prototype.valueOf%`, respectively. Our intention is to delete the "legacy" forms entirely in favor of the dotted forms. See whatwg/webidl#898 and whatwg/webidl#897.
|
What other repos will I need to update? |
domenic
approved these changes
Jun 18, 2020
There was a problem hiding this comment.
This LGTM (and note that this change is self-contained and has no dependency on Web IDL or other specs). I'll hold off on merging a bit to give others time to look at it, but thank you!
The only other spec I can think of that uses ES intrinsics directly is https://infra.spec.whatwg.org/#json
|
Can you or your employer sign the participant agreement at https://participate.whatwg.org/agreement? |
|
Thanks, I just signed the participation agreement; seems like it's awaiting verification. |
ljharb
added a commit
to ljharb/ecma262
that referenced
this pull request
Jun 19, 2020
All uses of these have been removed from HTML: - whatwg/webidl#898 - whatwg/html#5655 - whatwg/infra#316
ljharb
added a commit
to ljharb/ecma262
that referenced
this pull request
Jun 19, 2020
All uses of these have been removed from HTML: - whatwg/webidl#898 - whatwg/html#5655 - whatwg/infra#316
ljharb
added a commit
to ljharb/ecma262
that referenced
this pull request
Jun 19, 2020
All uses of these have been removed from HTML: - whatwg/webidl#898 - whatwg/html#5655 - whatwg/infra#316
ljharb
added a commit
to ljharb/ecma262
that referenced
this pull request
Jun 19, 2020
All uses of these have been removed from HTML: - whatwg/webidl#898 - whatwg/html#5655 - whatwg/infra#316
ljharb
added a commit
to ljharb/ecma262
that referenced
this pull request
Jun 24, 2020
All uses of these have been removed from HTML: - whatwg/webidl#898 - whatwg/html#5655 - whatwg/infra#316
ljharb
added a commit
to ljharb/ecma262
that referenced
this pull request
Aug 10, 2020
All uses of these have been removed from HTML: - whatwg/webidl#898 - whatwg/html#5655 - whatwg/infra#316
ljharb
added a commit
to ljharb/ecma262
that referenced
this pull request
Aug 11, 2020
All uses of these have been removed from HTML: - whatwg/webidl#898 - whatwg/html#5655 - whatwg/infra#316
ljharb
added a commit
to ljharb/ecma262
that referenced
this pull request
Aug 27, 2020
All uses of these have been removed from HTML: - whatwg/webidl#898 - whatwg/html#5655 - whatwg/infra#316
ljharb
added a commit
to ljharb/ecma262
that referenced
this pull request
Sep 2, 2020
All uses of these have been removed from HTML: - whatwg/webidl#898 - whatwg/html#5655 - whatwg/infra#316
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the ecma262 spec, we've added a new intrinsic notation form that will avoid unbounded growth of our list of intrinsics.
Specifically, things like
%ArrayPrototype%and%ObjProto_valueOf%should now be represented as%Array.prototype%and%Object.prototype.valueOf%, respectively.Our intention is to delete the "legacy" forms entirely in favor of the dotted forms.
See whatwg/webidl#898 and whatwg/webidl#897.