Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AppCache #6153

Merged
merged 1 commit into from
Dec 1, 2020
Merged

Remove AppCache #6153

merged 1 commit into from
Dec 1, 2020

Conversation

annevk
Copy link
Member

@annevk annevk commented Nov 17, 2020

This removes the manifest attribute on the html element, the text/cache-manifest format, the integration of application caches with navigation, the monkey patching of what is now Fetch, and the window.applicationCache API.

Closes #151 and closes #5505.

(See WHATWG Working Mode: Changes for more details.)


/browsing-the-web.html ( diff )
/iana.html ( diff )
/iframe-embed-object.html ( diff )
/index.html ( diff )
/indices.html ( diff )
/obsolete.html ( diff )
/parsing.html ( diff )
/rendering.html ( diff )
/semantics.html ( diff )
/system-state.html ( diff )
/web-messaging.html ( diff )
/webappapis.html ( diff )
/webstorage.html ( diff )
/window-object.html ( diff )
/workers.html ( diff )

Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So exciting!

This can also close #5505.

source Outdated
@@ -83816,7 +83691,6 @@ interface <dfn>Location</dfn> { // but see also <a href="#the-location-interface
<dt>a <span>JavaScript MIME type</span></dt>
<dt>a <span>JSON MIME type</span> that is not an <span>explicitly supported JSON MIME
type</span></dt>
<dt>"<code>text/cache-manifest</code>"</dt>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This removal would benefit from some (possibly manual?) tests. Although they might just uncover that this section is wrong and browsers generally treat text/* the same, in which case a followup bug would suffice.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

source Outdated
@@ -117171,6 +114695,9 @@ if (s = prompt('What is your name?')) {
<dt><dfn element-attr for="head"><code data-x="attr-head-profile">profile</code></dfn> on <code>head</code> elements</dt>
<dd><p>Unnecessary. Omit it altogether.</p></dd>

<dt><dfn element-attr for="html"><code data-x="attr-html-manifest">manifest</code></dfn> on <code>html</code> elements</dt>
<dd><p>Use service workers instead. <ref spec=SW></p></dd>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional: you could maybe port some major old IDs here, such as #appcache, #application-cache, and #offline.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After considering this a bit more I decided not to as there are a lot of IDs that end up being removed here and it's unclear which people relied on.

@quisquous
Copy link

The Chromium removal bug is https://bugs.chromium.org/p/chromium/issues/detail?id=582750

@rniwa
Copy link

rniwa commented Nov 22, 2020

We're interested in attempting to remove this feature but we need to understand the Web / app compatibility situation.

@ogaal894

This comment has been minimized.

This removes the manifest attribute on the html element, the text/cache-manifest format, the integration of application caches with navigation, the monkey patching of what is now Fetch, and the window.applicationCache API.

Closes #151 and closes #5505.
@annevk annevk requested a review from domenic November 30, 2020 13:29
@domenic
Copy link
Member

domenic commented Nov 30, 2020

Still LGTM. Excited to get this merged!

@annevk annevk merged commit e4330d5 into master Dec 1, 2020
@annevk annevk deleted the annevk/appcache branch December 1, 2020 09:29
@annevk
Copy link
Member Author

annevk commented Dec 1, 2020

sideshowbarker added a commit to w3c/browser-compat-data that referenced this pull request Dec 8, 2020
Per whatwg/html#6153 and
whatwg/html@e4330d5, the Application Cache
feature is no longer part of the HTML standard. So this change marks
both the applicationCache member of SharedWorkerGlobalScope and the
"manifest" attribute of the <html> element as standard_track:false.
@sideshowbarker
Copy link
Contributor

cc @whatwg/documentation

I raised mdn/browser-compat-data#7610 and updated the following MDN articles:

If I missed anything, let me know.

@chrisdavidmills
Copy link

Thanks @sideshowbarker ! On our side, we updated

So the status is clear.

Feel free to ping me if you notice any other docs bits that need updating.

ddbeck pushed a commit to mdn/browser-compat-data that referenced this pull request Dec 10, 2020
Per whatwg/html#6153 and
whatwg/html@e4330d5, the Application Cache
feature is no longer part of the HTML standard. So this change marks
both the applicationCache member of SharedWorkerGlobalScope and the
"manifest" attribute of the <html> element as standard_track:false.
andreubotella pushed a commit to andreubotella/html that referenced this pull request Jan 7, 2021
After the removal of AppCache in whatwg#6153, this algorithm is now unused.
annevk pushed a commit that referenced this pull request Jan 8, 2021
After the removal of AppCache in #6153, this algorithm is now unused.
@zcorpan zcorpan mentioned this pull request Jan 22, 2021
3 tasks
@whatwg whatwg deleted a comment from Ashegham Jun 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
removal/deprecation Removing or deprecating a feature topic: appcache
Development

Successfully merging this pull request may close these issues.

Integrate Fetch and "AppCache" or remove "AppCache"
7 participants