Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore COEP on non-secure contexts #6336

Merged
merged 3 commits into from
Feb 2, 2021
Merged

Ignore COEP on non-secure contexts #6336

merged 3 commits into from
Feb 2, 2021

Conversation

yutakahirano
Copy link
Member

@yutakahirano yutakahirano commented Jan 28, 2021 •
edited by pr-preview bot
Loading

Fixes #6328

  • At least two implementers are interested (and none opposed):
    • Firefox
    • Chrome
  • Tests are written and can be reviewed and commented upon at:
    • Already there: html/cross-origin-embedder-policy/no-secure-context.html
  • Implementation bugs are filed:
    • Chrome: Already implemented
    • Firefox: Already implemented
    • Safari: N/A: COEP has not been implemented yet

(See WHATWG Working Mode: Changes for more details.)

/browsing-the-web.html ( diff )
/origin.html ( diff )
/workers.html ( diff )

@yutakahirano yutakahirano mentioned this pull request Jan 28, 2021
Closed
@annevk annevk requested a review from zcorpan January 28, 2021 11:46
@annevk
Copy link
Member

annevk commented Jan 28, 2021

@camillelamy @ArthurSonzogni would you care to review as well?

@ArthurSonzogni
Copy link
Member

@camillelamy @ArthurSonzogni would you care to review as well?

Thanks! I took a look and it's great!

zcorpan
zcorpan approved these changes Feb 2, 2021
View reviewed changes
Copy link
Member

@zcorpan zcorpan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zcorpan
Copy link
Member

zcorpan commented Feb 2, 2021

The Build check is still waiting for a status. I'll close and reopen to see if that helps.

@zcorpan zcorpan closed this Feb 2, 2021
@zcorpan zcorpan reopened this Feb 2, 2021
@zcorpan
Copy link
Member

zcorpan commented Feb 2, 2021

And now it's green. @domenic, can you do a final editorial review and merge?

@domenic domenic merged commit a6b829b into whatwg:main Feb 2, 2021
@domenic domenic added the topic: cross-origin-embedder-policy Issues and ideas around the new "require CORP for subresource requests and frames and etc" proposal label Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcorpan zcorpan zcorpan approved these changes

Assignees
No one assigned
Labels
topic: cross-origin-embedder-policy Issues and ideas around the new "require CORP for subresource requests and frames and etc" proposal
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

COEP still doesn't check for HTTPS
5 participants
@yutakahirano @annevk @ArthurSonzogni @zcorpan @domenic