createImageBitmap: stop clipping sourceRect to the source's dimensions #6346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It has been found in whatwg#6306 that this was an oversight at the time of its introduction. Current behavior goes against web-authors expectations and no implementers has opposed against the change to "no-clip".
|
@whatwg/canvas could you please review this PR and the linked tests. Thanks! |
kdashg
approved these changes
Feb 2, 2021
kenrussell
approved these changes
Feb 2, 2021
|
@kenrussell @jdashg could you review web-platform-tests/wpt#27040 as well? |
|
Neither Ken nor I have write access, so our Approvals are treated as unofficial. It looks like we either need Approval from someone with existing write access, or we need to get added somehow. |
annevk
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Feb 4, 2021
annevk
approved these changes
Feb 4, 2021
|
Thanks everyone! (@jdashg yeah, the editors/maintainers (of which I'm one) sometimes delegate review to ensure all is in order with the technical change, and then only review editorial matters and ensure https://whatwg.org/working-mode#changes is followed.) |
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Feb 9, 2021
…ing, a=testonly Automatic update from web-platform-tests HTML: createImageBitmap() for out of bound clipping For whatwg/html#6346. -- wpt-commits: f480960da2cb3cc827f6fe4ac629b6dd229b0fea wpt-pr: 27040
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Feb 10, 2021
…ing, a=testonly Automatic update from web-platform-tests HTML: createImageBitmap() for out of bound clipping For whatwg/html#6346. -- wpt-commits: f480960da2cb3cc827f6fe4ac629b6dd229b0fea wpt-pr: 27040 UltraBlame original commit: 10a1015aa806f8b426d358d9f4546a2240b6b8ee
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Feb 10, 2021
…ing, a=testonly Automatic update from web-platform-tests HTML: createImageBitmap() for out of bound clipping For whatwg/html#6346. -- wpt-commits: f480960da2cb3cc827f6fe4ac629b6dd229b0fea wpt-pr: 27040 UltraBlame original commit: 10a1015aa806f8b426d358d9f4546a2240b6b8ee
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Feb 10, 2021
…ing, a=testonly Automatic update from web-platform-tests HTML: createImageBitmap() for out of bound clipping For whatwg/html#6346. -- wpt-commits: f480960da2cb3cc827f6fe4ac629b6dd229b0fea wpt-pr: 27040 UltraBlame original commit: 10a1015aa806f8b426d358d9f4546a2240b6b8ee
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Feb 11, 2021
…ing, a=testonly Automatic update from web-platform-tests HTML: createImageBitmap() for out of bound clipping For whatwg/html#6346. -- wpt-commits: f480960da2cb3cc827f6fe4ac629b6dd229b0fea wpt-pr: 27040
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the specs ask that when a ImageBitmap is created, its source rectangle should get clipped to the source image's dimensions.
It has been found in #6306 that this was an oversight at the time of its introduction.
Current behavior goes against web-authors expectations and no implementer has opposed against the change to "no-clip".
(See WHATWG Working Mode: Changes for more details.)
/imagebitmap-and-animations.html ( diff )