Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set dfn-type on definitions #6361

Merged
merged 3 commits into from
Feb 5, 2021
Merged

Set dfn-type on definitions #6361

merged 3 commits into from
Feb 5, 2021

Conversation

Follow-up to:

* #5694
* #5916

...setting dfn types on more items identified by reffy
@sideshowbarker
Copy link
Contributor Author

This is ready for review. Rather than trying to review the full diff against main, the three commits may be easier to review individually:

Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a spot check of each commit and it all looks good. Hooray!

@domenic domenic merged commit 3beb2e3 into main Feb 5, 2021
@domenic domenic deleted the sideshowbarker/set-dfn-type-2 branch February 5, 2021 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants